Repository navigation
[CI only] upstream#141 merged onto upstream main - #1
Closed
KevinTCoughlin wants to merge 4 commits into
Closed
KevinTCoughlin wants to merge 4 commits into
KevinTCoughlin wants to merge 4 commits into
Conversation
Seeking jumps to a byte offset proportional to the requested time and keeps the requested time as the new position. FLAC is variable bitrate, so the frame found at that offset can be seconds away from it, and the error carries on into `progress` until the end of the track (dimitris-c#133). After a FLAC seek, read the first frame's header (RFC 9639, 9.1) and use the sample number it records as the seek time. The header is validated with its CRC-8; when it can't be parsed the previous behaviour is kept.
…mitris-c#152) seek(to:) schedules processSource, which returns early while the player is paused. resume() never scheduled it again, so unless new data arrived the seek stayed pending: progress reported the target and playback did not move. Schedule processSource on resume, as pause() already does.
…imitris-c#148) The IO thread keeps pulling from the render callback until the hardware is stopped. Releasing an AudioPlayer while it was still rendering (e.g. after an error, where pause() is a no-op) freed inOutAudioBufferList while the render block still used it and crashed in AVAudioEngineGraph::RenderToABL. Stop the hardware first, then the engine, so the IO thread does not call the manual rendering block of a stopped engine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway PR in the fork to run CI on dimitris-c#141 rebased onto current upstream main (Xcode not installed locally). Not for merge.
🤖 Generated with Claude Code