Skip to content

[CI only] upstream#141 merged onto upstream main - #1

Closed
KevinTCoughlin wants to merge 4 commits into
mainfrom
review/pr-141-on-main
Closed

KevinTCoughlin wants to merge 4 commits into
mainfrom
review/pr-141-on-main

Conversation

@KevinTCoughlin

Copy link
Copy Markdown
Owner

Throwaway PR in the fork to run CI on dimitris-c#141 rebased onto current upstream main (Xcode not installed locally). Not for merge.

🤖 Generated with Claude Code

Minidoracat and others added 4 commits October 5, 2026 13:17
Seeking jumps to a byte offset proportional to the requested time and
keeps the requested time as the new position. FLAC is variable bitrate,
so the frame found at that offset can be seconds away from it, and the
error carries on into `progress` until the end of the track (dimitris-c#133).

After a FLAC seek, read the first frame's header (RFC 9639, 9.1) and use
the sample number it records as the seek time. The header is validated
with its CRC-8; when it can't be parsed the previous behaviour is kept.
…mitris-c#152)

seek(to:) schedules processSource, which returns early while the player
is paused. resume() never scheduled it again, so unless new data arrived
the seek stayed pending: progress reported the target and playback did
not move. Schedule processSource on resume, as pause() already does.
…imitris-c#148)

The IO thread keeps pulling from the render callback until the hardware is
stopped. Releasing an AudioPlayer while it was still rendering (e.g. after
an error, where pause() is a no-op) freed inOutAudioBufferList while the
render block still used it and crashed in AVAudioEngineGraph::RenderToABL.

Stop the hardware first, then the engine, so the IO thread does not call
the manual rendering block of a stopped engine.
@KevinTCoughlin
KevinTCoughlin deleted the review/pr-141-on-main branch November 12, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants